lkml.org 
[lkml]   [2019]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] KVM: LAPIC: lapic timer is injected by posted interrupt
From
Date
On 05/06/19 12:09, Wanpeng Li wrote:
> +static void apic_timer_expired_pi(struct kvm_lapic *apic)
> +{
> + struct kvm_timer *ktimer = &apic->lapic_timer;
> +
> + kvm_apic_local_deliver(apic, APIC_LVTT);
> + if (apic_lvtt_tscdeadline(apic))
> + ktimer->tscdeadline = 0;
> + if (apic_lvtt_oneshot(apic)) {
> + ktimer->tscdeadline = 0;
> + ktimer->target_expiration = 0;
> + }
> +}

Please rename this function to kvm_apic_inject_pending_timer_irqs and
call it from kvm_inject_apic_timer_irqs.

Then apic_timer_expired can just do

if (atomic_read(&apic->lapic_timer.pending))
return;

+ if (unlikely(posted_interrupt_inject_timer(apic->vcpu))) {
+ kvm_apic_inject_pending_timer_irqs(apic);
+ return;
+ }

etc.

Paolo

\
 
 \ /
  Last update: 2019-06-05 14:31    [W:0.085 / U:23.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site