Messages in this thread | | | Date | Wed, 5 Jun 2019 12:13:17 +0200 | From | Torsten Duwe <> | Subject | Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I |
| |
On Tue, Jun 04, 2019 at 08:08:40AM -0700, Vasily Khoruzhick wrote: > On Tue, Jun 4, 2019 at 5:23 AM Torsten Duwe <duwe@lst.de> wrote: > > > > Teres-I has an anx6345 bridge connected to the RGB666 LCD output, and > > the I2C controlling signals are connected to I2C0 bus. eDP output goes > > to an Innolux N116BGE panel. > > > > Enable it in the device tree. > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > > Signed-off-by: Torsten Duwe <duwe@suse.de> > > --- > > .../boot/dts/allwinner/sun50i-a64-teres-i.dts | 65 ++++++++++++++++++++-- > > 1 file changed, 61 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts > > index 0ec46b969a75..a0ad438b037f 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts > > @@ -65,6 +65,21 @@ > > }; > > }; > > > > + panel: panel { > > + compatible ="innolux,n116bge", "simple-panel"; > > It's still "simple-panel". I believe I already mentioned that Rob > asked it to be edp-connector. > For which there are neither bindings nor drivers.
Is anybody seriously proposing to hold back support for existing (open source!) hardware in favour of an *imaginable* *possibly* better solution? Especially when this exact line is already used in some other places? (there's a space missing btw...)
I'm more than glad to follow any constructive improvements towards better modularity. However there were none so far, and on top of that, it's a laptop. I see little advantage in mentioning an internal connector when the panel connected is always the same.
FWIW, Rob should also have received these patches.
Torsten
| |