Messages in this thread | | | Subject | Re: [PATCH v2 3/3] xen/swiotlb: remember having called xen_create_contiguous_region() | From | Juergen Gross <> | Date | Wed, 5 Jun 2019 10:37:35 +0200 |
| |
On 31.05.19 13:38, Juergen Gross wrote: > On 30/05/2019 14:46, Boris Ostrovsky wrote: >> On 5/30/19 5:04 AM, Christoph Hellwig wrote: >>> Please don't add your private flag to page-flags.h. The whole point of >>> the private flag is that you can use it in any way you want withou >>> touching the common code. >> >> >> There is already a bunch of aliases for various sub-components >> (including Xen) in page-flags.h for private flags, which is why I >> suggested we do the same for the new use case. Adding this new alias >> will keep flag usage consistent. > > What about me adding another patch moving those Xen private aliases > into arch/x86/include/asm/xen/page.h ?
This is becoming difficult.
I'd need to remove the "#undef PF_NO_COMPOUND" from page-flags.h or to #include a (new) xen/page-flags.h from page-flags.h after all the defines are ready. Is that really worth the effort given that other components (e.g. file systems) are doing the same?
Juergen
| |