lkml.org 
[lkml]   [2019]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/8] dmaengine: fsl-edma: add drvdata for vf610
On 29-05-19, 17:08, yibin.gong@nxp.com wrote:

> @@ -205,8 +228,9 @@ static int fsl_edma_probe(struct platform_device *pdev)
> if (!fsl_edma)
> return -ENOMEM;
>
> - fsl_edma->version = v1;
> - fsl_edma->dmamux_nr = DMAMUX_NR;
> + fsl_edma->drvdata = drvdata;
> + fsl_edma->version = drvdata->version;
> + fsl_edma->dmamux_nr = drvdata->dmamuxs;

And can we avoid the duplication here, you have version and dmamuxs
represented in two places. But right now it looks logical so the removal
should be done after this series

--
~Vinod

\
 
 \ /
  Last update: 2019-06-04 14:37    [W:0.069 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site