Messages in this thread | | | Subject | Re: [PATCH] ocxl: do not use C++ style comments in uapi header | From | Frederic Barrat <> | Date | Tue, 4 Jun 2019 13:51:45 +0200 |
| |
Le 04/06/2019 à 13:16, Masahiro Yamada a écrit : > Linux kernel tolerates C++ style comments these days. Actually, the > SPDX License tags for .c files start with //. > > On the other hand, uapi headers are written in more strict C, where > the C++ comment style is forbidden. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > ---
Thanks! Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> > include/uapi/misc/ocxl.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/uapi/misc/ocxl.h b/include/uapi/misc/ocxl.h > index 97937cfa3baa..6d29a60a896a 100644 > --- a/include/uapi/misc/ocxl.h > +++ b/include/uapi/misc/ocxl.h > @@ -33,23 +33,23 @@ struct ocxl_ioctl_attach { > }; > > struct ocxl_ioctl_metadata { > - __u16 version; // struct version, always backwards compatible > + __u16 version; /* struct version, always backwards compatible */ > > - // Version 0 fields > + /* Version 0 fields */ > __u8 afu_version_major; > __u8 afu_version_minor; > - __u32 pasid; // PASID assigned to the current context > + __u32 pasid; /* PASID assigned to the current context */ > > - __u64 pp_mmio_size; // Per PASID MMIO size > + __u64 pp_mmio_size; /* Per PASID MMIO size */ > __u64 global_mmio_size; > > - // End version 0 fields > + /* End version 0 fields */ > > - __u64 reserved[13]; // Total of 16*u64 > + __u64 reserved[13]; /* Total of 16*u64 */ > }; > > struct ocxl_ioctl_p9_wait { > - __u16 thread_id; // The thread ID required to wake this thread > + __u16 thread_id; /* The thread ID required to wake this thread */ > __u16 reserved1; > __u32 reserved2; > __u64 reserved3[3]; >
| |