lkml.org 
[lkml]   [2019]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v4 4/9] ASoC: sun4i-i2s: Reduce quirks for sun8i-h3
    On Tue, 4 Jun 2019 at 09:46, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
    >
    > On Mon, Jun 03, 2019 at 07:47:30PM +0200, codekipper@gmail.com wrote:
    > > From: Marcus Cooper <codekipper@gmail.com>
    > >
    > > We have a number of flags used to identify the functionality
    > > of the IP block found on the sun8i-h3 and later devices. As it
    > > is only neccessary to identify this new block then replace
    > > these flags with just one.
    > >
    > > Signed-off-by: Marcus Cooper <codekipper@gmail.com>
    >
    > This carries exactly the same meaning than the compatible, so this is
    > entirely redundant.
    >
    > The more I think of it, the more I fell like we should have function
    > pointers instead, and have hooks to deal with these kind of things.
    >
    > I've been working a lot on that driver recently, and there's some many
    > parameters and regmap_fields that it becomes pretty hard to work on.
    Hi Maxime,
    let's sync with what you're doing as you're more lightly to see it
    through to delivery!
    I was trying to clean up the driver as some of this seemed a bit unnecessary,
    hooks sounds like the way forward,
    CK
    >
    > Maxime
    >
    > --
    > Maxime Ripard, Bootlin
    > Embedded Linux and Kernel engineering
    > https://bootlin.com

    \
     
     \ /
      Last update: 2019-06-04 11:34    [W:4.790 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site