Messages in this thread | | | Date | Tue, 4 Jun 2019 07:33:30 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] driver core: show the error number when driver_sysfs_add() fails |
| |
On Tue, Jun 04, 2019 at 12:15:46PM +0800, Kefeng Wang wrote: > If driver_sysfs_add() fails, kernel shows following message, > > really_probe: driver_sysfs_add(portman.0) failed > ppdev: probe of portman.0 failed with error 0 > > It's better to show the error number like other probe_failed path. > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > --- > drivers/base/dd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/dd.c b/drivers/base/dd.c > index 0df9b4461766..04ee4e196530 100644 > --- a/drivers/base/dd.c > +++ b/drivers/base/dd.c > @@ -493,7 +493,8 @@ static int really_probe(struct device *dev, struct device_driver *drv) > goto probe_failed; > } > > - if (driver_sysfs_add(dev)) { > + ret = driver_sysfs_add(dev); > + if (ret) { > printk(KERN_ERR "%s: driver_sysfs_add(%s) failed\n", > __func__, dev_name(dev));
Shouldn't this be where the error number is shown? No need for all callers to also show the same thing.
thanks,
greg k-h
| |