Messages in this thread | | | Date | Tue, 4 Jun 2019 16:09:51 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH v4 1/2] fTPM: firmware TPM running in TEE |
| |
On Tue, Jun 04, 2019 at 11:45:52AM +0530, Sumit Garg wrote: >On Thu, 30 May 2019 at 20:58, Sasha Levin <sashal@kernel.org> wrote: >> + /* Open context with TEE driver */ >> + pvt_data->ctx = tee_client_open_context(NULL, ftpm_tee_match, NULL, >> + NULL); >> + if (IS_ERR(pvt_data->ctx)) { >> + dev_err(dev, "%s:tee_client_open_context failed\n", __func__); > >Is this well tested? I see this misleading error multiple times as >follows although TEE driver works pretty well.
Yes, this was all functionally tested.
Why is this error message misleading? I'd be happy to fix it.
>Module built with "CONFIG_TCG_FTPM_TEE=y" > >[ 1.436878] ftpm-tee tpm@0: ftpm_tee_probe:tee_client_open_context failed >[ 1.509471] ftpm-tee tpm@0: ftpm_tee_probe:tee_client_open_context failed >[ 1.517268] ftpm-tee tpm@0: ftpm_tee_probe:tee_client_open_context failed >[ 1.525596] ftpm-tee tpm@0: ftpm_tee_probe:tee_client_open_context failed
Does the TEE have the fTPM implementation and such? Could you provide details about your testing environment (hardware, fTPM verions, etc)?
-- Thanks, Sasha
| |