lkml.org 
[lkml]   [2019]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v4 11/12] drm/virtio: switch from ttm to gem shmem helpers
    On Fri, Jun 28, 2019 at 3:49 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
    >
    > > > static inline struct virtio_gpu_object*
    > > > virtio_gpu_object_ref(struct virtio_gpu_object *bo)
    >
    > > The last users of these two helpers are removed with this patch. We
    > > can remove them.
    >
    > patch 12/12 does that.
    I meant virtio_gpu_object_ref/unref, which are still around after patch 12.
    >
    > > > + bo = gem_to_virtio_gpu_obj(&shmem_obj->base);
    > > > + bo->base.base.funcs = &virtio_gpu_gem_funcs;
    > > Move this to virtio_gpu_create_object.
    >
    > Fixed.
    >
    > > > + ret = drm_gem_shmem_pin(&obj->base.base);
    > > The bo is attached for its entire lifetime, at least currently. Maybe
    > > we can use drm_gem_shmem_get_pages_sgt (and get rid of obj->pages).
    >
    > Already checked this.
    > We can't due to the iommu quirks.
    >
    > cheers,
    > Gerd
    >

    \
     
     \ /
      Last update: 2019-06-30 20:43    [W:3.151 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site