Messages in this thread | | | From | Masahiro Yamada <> | Date | Tue, 4 Jun 2019 02:16:16 +0900 | Subject | Re: [Intel-gfx] [RFC 1/3] kbuild: add support for ensuring headers are self-contained |
| |
Hi Jani,
On Mon, May 20, 2019 at 6:16 PM Jani Nikula <jani.nikula@intel.com> wrote: > > > > > I will take a little time to considier > > how far we can extend the idea about > > "headers should be self-contained". > > Thanks! Please let me know if/when you need further action from me, I > won't post new versions until then.
Could you send v2 with the following changes ?
[1] Could you rename *.header_test.c to *.hdrtest.c ? (I just thought .header_test.c was a bit too long.)
[2] %.hdrtest.c should not depend on the header
This will avoid unnecessary regeneration of *.hdrtest.c
quiet_cmd_header_test = HDRTEST $@ cmd_header_test = echo "\#include \"$*.h\"" > $@
$(obj)/%.hdrtest.c: $(call cmd,header_test)
[3] Please add '*.hdrtest.c' to .gitignore, Documentation/dontdiff
[4] Please add '*.hdrtest.c' to 'make clean' (around line 1640 of top Makefile)
-- Best Regards Masahiro Yamada
| |