lkml.org 
[lkml]   [2019]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] timers: Fix up get_target_base() to use old base properly
    Date
    get_target_base() in the timer code is not using the "base" parameter
    at all. My gut feeling is that instead of removing that extra
    parameter, what we really want to do is "return the old base if it
    does not suite for a new one".

    CC: Thomas Gleixner <tglx@linutronix.de>
    CC: John Stultz <john.stultz@linaro.org>
    CC: Stephen Boyd <sboyd@kernel.org>
    CC: Luiz Capitulino <lcapitulino@redhat.com>
    CC: Marcelo Tosatti <mtosatti@redhat.com>
    CC: linux-kernel@vger.kernel.org
    Signed-off-by: Peter Xu <peterx@redhat.com>
    ---
    kernel/time/timer.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/time/timer.c b/kernel/time/timer.c
    index 343c7ba33b1c..6ff6ffd2c719 100644
    --- a/kernel/time/timer.c
    +++ b/kernel/time/timer.c
    @@ -868,7 +868,7 @@ get_target_base(struct timer_base *base, unsigned tflags)
    !(tflags & TIMER_PINNED))
    return get_timer_cpu_base(tflags, get_nohz_timer_target());
    #endif
    - return get_timer_this_cpu_base(tflags);
    + return base;
    }

    static inline void forward_timer_base(struct timer_base *base)
    --
    2.17.1
    \
     
     \ /
      Last update: 2019-06-03 15:31    [W:8.479 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site