lkml.org 
[lkml]   [2019]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:sched/core] sched/debug: Remove sd->*_idx range on sysctl
    Commit-ID:  3d8d53554405952993bb0279ef3ebebc51740074
    Gitweb: https://git.kernel.org/tip/3d8d53554405952993bb0279ef3ebebc51740074
    Author: Dietmar Eggemann <dietmar.eggemann@arm.com>
    AuthorDate: Mon, 27 May 2019 07:21:12 +0100
    Committer: Ingo Molnar <mingo@kernel.org>
    CommitDate: Mon, 3 Jun 2019 11:49:39 +0200

    sched/debug: Remove sd->*_idx range on sysctl

    This reverts:

    commit 201c373e8e48 ("sched/debug: Limit sd->*_idx range on sysctl")

    Load indexes (sd->*_idx) are no longer needed without rq->cpu_load[].
    The range check for load indexes can be removed as well. Get rid of it
    before the rq->cpu_load[] since it uses CPU_LOAD_IDX_MAX.

    At the same time, fix the following coding style issues detected by
    scripts/checkpatch.pl:

    ERROR: space prohibited before that ','
    ERROR: space prohibited before that close parenthesis ')'

    Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Acked-by: Rik van Riel <riel@surriel.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Morten Rasmussen <morten.rasmussen@arm.com>
    Cc: Patrick Bellasi <patrick.bellasi@arm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Quentin Perret <quentin.perret@arm.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Valentin Schneider <valentin.schneider@arm.com>
    Cc: Vincent Guittot <vincent.guittot@linaro.org>
    Link: https://lkml.kernel.org/r/20190527062116.11512-4-dietmar.eggemann@arm.com
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    ---
    kernel/sched/debug.c | 37 ++++++++++++++-----------------------
    1 file changed, 14 insertions(+), 23 deletions(-)

    diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
    index 150043e1d716..5c7b066d7de6 100644
    --- a/kernel/sched/debug.c
    +++ b/kernel/sched/debug.c
    @@ -236,25 +236,16 @@ static void sd_free_ctl_entry(struct ctl_table **tablep)
    *tablep = NULL;
    }

    -static int min_load_idx = 0;
    -static int max_load_idx = CPU_LOAD_IDX_MAX-1;
    -
    static void
    set_table_entry(struct ctl_table *entry,
    const char *procname, void *data, int maxlen,
    - umode_t mode, proc_handler *proc_handler,
    - bool load_idx)
    + umode_t mode, proc_handler *proc_handler)
    {
    entry->procname = procname;
    entry->data = data;
    entry->maxlen = maxlen;
    entry->mode = mode;
    entry->proc_handler = proc_handler;
    -
    - if (load_idx) {
    - entry->extra1 = &min_load_idx;
    - entry->extra2 = &max_load_idx;
    - }
    }

    static struct ctl_table *
    @@ -265,19 +256,19 @@ sd_alloc_ctl_domain_table(struct sched_domain *sd)
    if (table == NULL)
    return NULL;

    - set_table_entry(&table[0] , "min_interval", &sd->min_interval, sizeof(long), 0644, proc_doulongvec_minmax, false);
    - set_table_entry(&table[1] , "max_interval", &sd->max_interval, sizeof(long), 0644, proc_doulongvec_minmax, false);
    - set_table_entry(&table[2] , "busy_idx", &sd->busy_idx, sizeof(int) , 0644, proc_dointvec_minmax, true );
    - set_table_entry(&table[3] , "idle_idx", &sd->idle_idx, sizeof(int) , 0644, proc_dointvec_minmax, true );
    - set_table_entry(&table[4] , "newidle_idx", &sd->newidle_idx, sizeof(int) , 0644, proc_dointvec_minmax, true );
    - set_table_entry(&table[5] , "wake_idx", &sd->wake_idx, sizeof(int) , 0644, proc_dointvec_minmax, true );
    - set_table_entry(&table[6] , "forkexec_idx", &sd->forkexec_idx, sizeof(int) , 0644, proc_dointvec_minmax, true );
    - set_table_entry(&table[7] , "busy_factor", &sd->busy_factor, sizeof(int) , 0644, proc_dointvec_minmax, false);
    - set_table_entry(&table[8] , "imbalance_pct", &sd->imbalance_pct, sizeof(int) , 0644, proc_dointvec_minmax, false);
    - set_table_entry(&table[9] , "cache_nice_tries", &sd->cache_nice_tries, sizeof(int) , 0644, proc_dointvec_minmax, false);
    - set_table_entry(&table[10], "flags", &sd->flags, sizeof(int) , 0644, proc_dointvec_minmax, false);
    - set_table_entry(&table[11], "max_newidle_lb_cost", &sd->max_newidle_lb_cost, sizeof(long), 0644, proc_doulongvec_minmax, false);
    - set_table_entry(&table[12], "name", sd->name, CORENAME_MAX_SIZE, 0444, proc_dostring, false);
    + set_table_entry(&table[0], "min_interval", &sd->min_interval, sizeof(long), 0644, proc_doulongvec_minmax);
    + set_table_entry(&table[1], "max_interval", &sd->max_interval, sizeof(long), 0644, proc_doulongvec_minmax);
    + set_table_entry(&table[2], "busy_idx", &sd->busy_idx, sizeof(int), 0644, proc_dointvec_minmax);
    + set_table_entry(&table[3], "idle_idx", &sd->idle_idx, sizeof(int), 0644, proc_dointvec_minmax);
    + set_table_entry(&table[4], "newidle_idx", &sd->newidle_idx, sizeof(int), 0644, proc_dointvec_minmax);
    + set_table_entry(&table[5], "wake_idx", &sd->wake_idx, sizeof(int), 0644, proc_dointvec_minmax);
    + set_table_entry(&table[6], "forkexec_idx", &sd->forkexec_idx, sizeof(int), 0644, proc_dointvec_minmax);
    + set_table_entry(&table[7], "busy_factor", &sd->busy_factor, sizeof(int), 0644, proc_dointvec_minmax);
    + set_table_entry(&table[8], "imbalance_pct", &sd->imbalance_pct, sizeof(int), 0644, proc_dointvec_minmax);
    + set_table_entry(&table[9], "cache_nice_tries", &sd->cache_nice_tries, sizeof(int), 0644, proc_dointvec_minmax);
    + set_table_entry(&table[10], "flags", &sd->flags, sizeof(int), 0644, proc_dointvec_minmax);
    + set_table_entry(&table[11], "max_newidle_lb_cost", &sd->max_newidle_lb_cost, sizeof(long), 0644, proc_doulongvec_minmax);
    + set_table_entry(&table[12], "name", sd->name, CORENAME_MAX_SIZE, 0444, proc_dostring);
    /* &table[13] is terminator */

    return table;
    \
     
     \ /
      Last update: 2019-06-03 15:04    [W:5.150 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site