Messages in this thread | | | Date | Fri, 28 Jun 2019 13:37:02 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] ftrace: Remove possible deadlock between register_kprobe() and ftrace_run_update_code() |
| |
On Fri, 28 Jun 2019 19:33:30 +0200 (CEST) Jiri Kosina <jikos@kernel.org> wrote:
> On Thu, 27 Jun 2019, Josh Poimboeuf wrote: > > > > How is that supposed to work? > > > > > > ftrace > > > prepare() > > > setrw() > > > setro() > > > patch <- FAIL > > > > /me dodges frozen shark > > > > You are right of course. My brain has apparently already shut off for > > the day. > > > > Maybe a comment or two would help though. > > I'd actually prefer (perhaps in parallel to the comment) using the > __acquires() and __releases() anotations, so that sparse and friends don't > get confused by that either. >
Care to send a patch? :-)
-- Steve
| |