lkml.org 
[lkml]   [2019]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] drivers/staging/rtl8192u: drop first comment line
On Thu, Jun 27, 2019 at 10:33:35AM +0200, Christian Müller wrote:
> As stated in coding-styles.rst multiline comments should be structured in a way,
> that the actual comment starts on the second line of the commented portion. E.g:
>
> /*
> * Multiline comments
> * should look like
> * this.
> */
>
> However, there is an exception to files in drivers/net/ and net/, where
> multiline comments are prefered to look like this:
>
> /* Mutliline comments for
> * drivers/net/ should look
> * like this.
> */
>
> The comments in this file initially looked like the first example.
> But since this file is part of a networking driver and thus should
> be moved to drivers/net/ one day, this patch adjusts the comments
> such that they are fitting to the style imposed for drivers/net/.
>
> Signed-off-by: Christian Müller <muellerch-privat@web.de>
> Signed-off-by: Felix Trommer <felix.trommer@hotmail.de>
> ---
> drivers/staging/rtl8192u/r8192U_dm.c | 69 ++++++++++------------------
> 1 file changed, 23 insertions(+), 46 deletions(-)

What changed from v1? That always goes below the --- line.

Please fix up and send v3.

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-06-27 18:46    [W:0.118 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site