Messages in this thread | | | Subject | Re: [PATCH v3 1/5] gem/vram: pin to vram in vmap | From | Thomas Zimmermann <> | Date | Thu, 27 Jun 2019 17:59:05 +0200 |
| |
Am 27.06.19 um 17:54 schrieb Thomas Zimmermann: > Hi > > Am 27.06.19 um 17:16 schrieb Gerd Hoffmann: >> Hi, >> >>> 1) Introduce a default_placement field in struct drm_gem_vram_helper >>> where this flag can be configured. I'd favor this option. >> >>> 2) Introduce a separate callback function for pinning to vram. The >>> driver would have to set the correct function pointers. >> >>> 3) Pin the fb console buffer manually from within the bochs driver. >> >> Hmm. Before calling drm_fbdev_generic_setup() the bo doesn't exist yet >> and when the function returns it is already vmapped and pinned I think. >> >> So (3) isn't easily doable. (1) looks best to me. > > For my patches, it's OK to have to BO pinned to VRAM by default. As the > BO will be unmapped most of the time, I can change this flag at any time.
So, yeah, option 1 ...
> Best regards > Thomas > >> cheers, >> Gerd >> > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel >
-- Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)
[unhandled content-type:application/pgp-signature]
| |