lkml.org 
[lkml]   [2019]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 2/2] iio: cros_ec: Extend legacy support to ARM device
Hi,

Missatge de Doug Anderson <dianders@chromium.org> del dia dc., 26 de
juny 2019 a les 23:06:
>
> Hi,
>
> On Mon, Jun 24, 2019 at 3:53 PM Gwendal Grignou <gwendal@chromium.org> wrote:
> >
> > -static int read_ec_accel_data(struct cros_ec_accel_legacy_state *st,
> > - unsigned long scan_mask, s16 *data)
> > +int cros_ec_accel_legacy_read_cmd(struct iio_dev *indio_dev,
> > + unsigned long scan_mask, s16 *data)
>
> As found by 0day (see https://crrev.com/c/1678822), the
> cros_ec_accel_legacy_read_cmd() should have been static.
>
> I presume this will cause less confusion if a maintainer just fixes
> this up when landing the patch so Gwendal shouldn't send out a new
> version to fix it. ...but if this is not the case then yell! :-)
>

As probably will go through the chrome-platform tree I'll fix this
when I apply the patch. No need to resend.

Gwendal, Doug, to have cros-ec-sensors legacy support for ARM in
upstream, could you spend 5 min reviewing the following patch?

https://lore.kernel.org/patchwork/patch/1094790/

I'll also test it.

Thanks,
~ Enric

> -Doug

\
 
 \ /
  Last update: 2019-06-27 17:36    [W:0.050 / U:1.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site