Messages in this thread | | | From | Nick Desaulniers <> | Date | Thu, 27 Jun 2019 16:19:14 -0700 | Subject | Re: [PATCH] clk: qoriq: Fix -Wunused-const-variable |
| |
On Thu, Jun 27, 2019 at 3:06 PM 'Nathan Huckleberry' via Clang Built Linux <clang-built-linux@googlegroups.com> wrote: > > drivers/clk/clk-qoriq.c:138:38: warning: unused variable > 'p5020_cmux_grp1' [-Wunused-const-variable] static const struct > clockgen_muxinfo p5020_cmux_grp1 > > drivers/clk/clk-qoriq.c:146:38: warning: unused variable > 'p5020_cmux_grp2' [-Wunused-const-variable] static const struct > clockgen_muxinfo p5020_cmux_grp2 > > In the definition of the p5020 chip, the p2041 chip's info was used > instead. The p5020 and p2041 chips have different info. This is most > likely a typo.
oops! Further, the definitions of p5020_cmux_grp1/p5020_cmux_grp2 are subtly different than p2041_cmux_grp1/p2041_cmux_grp2. Definitely looks copy+pasta related; I agree with your assessment. (Also, it's interesting to see this sparse array initializer syntax). Thanks for the patch. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> > Link: https://github.com/ClangBuiltLinux/linux/issues/525 > Cc: clang-built-linux@googlegroups.com > Signed-off-by: Nathan Huckleberry <nhuck@google.com> > --- > drivers/clk/clk-qoriq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c > index 4739a47ec8bd..0f8870527940 100644 > --- a/drivers/clk/clk-qoriq.c > +++ b/drivers/clk/clk-qoriq.c > @@ -678,7 +678,7 @@ static const struct clockgen_chipinfo chipinfo[] = { > .guts_compat = "fsl,qoriq-device-config-1.0", > .init_periph = p5020_init_periph, > .cmux_groups = { > - &p2041_cmux_grp1, &p2041_cmux_grp2 > + &p5020_cmux_grp1, &p5020_cmux_grp2
-- Thanks, ~Nick Desaulniers
| |