lkml.org 
[lkml]   [2019]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 04/25] mm: remove MEMORY_DEVICE_PUBLIC support
    [ add Ira ]

    On Wed, Jun 26, 2019 at 5:27 AM Christoph Hellwig <hch@lst.de> wrote:
    >
    > The code hasn't been used since it was added to the tree, and doesn't
    > appear to actually be usable.
    >
    > Signed-off-by: Christoph Hellwig <hch@lst.de>
    > Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
    > Acked-by: Michal Hocko <mhocko@suse.com>
    [..]
    > diff --git a/mm/swap.c b/mm/swap.c
    > index 7ede3eddc12a..83107410d29f 100644
    > --- a/mm/swap.c
    > +++ b/mm/swap.c
    > @@ -740,17 +740,6 @@ void release_pages(struct page **pages, int nr)
    > if (is_huge_zero_page(page))
    > continue;
    >
    > - /* Device public page can not be huge page */
    > - if (is_device_public_page(page)) {
    > - if (locked_pgdat) {
    > - spin_unlock_irqrestore(&locked_pgdat->lru_lock,
    > - flags);
    > - locked_pgdat = NULL;
    > - }
    > - put_devmap_managed_page(page);
    > - continue;
    > - }
    > -

    This collides with Ira's bug fix [1]. The MEMORY_DEVICE_FSDAX case
    needs this to be converted to be independent of "public" pages.
    Perhaps it should be pulled out of -mm and incorporated in this
    series.

    [1]: https://lore.kernel.org/lkml/20190605214922.17684-1-ira.weiny@intel.com/

    \
     
     \ /
      Last update: 2019-06-26 18:01    [W:3.430 / U:0.512 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site