Messages in this thread | | | Date | Wed, 26 Jun 2019 12:23:31 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] ASoC: codecs: ad193x: Reset DAC Control 1 register at probe |
| |
On Wed, Jun 26, 2019 at 01:49:47PM +0300, Codrin Ciubotariu wrote: > Since the ad193x codecs have no software reset, we have to reinitialize the > registers after a hardware reset. For example, if we change the > device-tree between these resets, changing the audio format of the DAI link > from DSP_A with 8 TDM channels to I2S 2 channels, DAC Control 1 register > will remain configured for 8 channels. This patch resets this register at > probe to its default value.
Would it not be more robust/complete to have a set of register defaults and write the whole lot out rather than individually going through and adding writes for specific registers as needed? [unhandled content-type:application/pgp-signature] | |