lkml.org 
[lkml]   [2019]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RESEND] staging: erofs: remove unsupported ->datamode check in fill_inline_data()
From
Date
Hi Yue,

On 2019/6/26 11:28, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
>
> Already check if ->datamode is supported in read_inode(), no need to check
> again in the next fill_inline_data() only called by fill_inode().
>
> Signed-off-by: Yue Hu <huyue2@yulong.com>

You should add all the 'Reviewed-by' / 'Acked-by' / ... tags from other guyes
to the following versions when you resend your patches.

Thanks,
Gao Xiang

> ---
> drivers/staging/erofs/inode.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
> index e51348f..d6e1e16 100644
> --- a/drivers/staging/erofs/inode.c
> +++ b/drivers/staging/erofs/inode.c
> @@ -129,8 +129,6 @@ static int fill_inline_data(struct inode *inode, void *data,
> struct erofs_sb_info *sbi = EROFS_I_SB(inode);
> const int mode = vi->datamode;
>
> - DBG_BUGON(mode >= EROFS_INODE_LAYOUT_MAX);
> -
> /* should be inode inline C */
> if (mode != EROFS_INODE_LAYOUT_INLINE)
> return 0;
>

\
 
 \ /
  Last update: 2019-06-26 11:03    [W:0.070 / U:0.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site