Messages in this thread | | | Date | Tue, 25 Jun 2019 09:25:39 -0500 | From | Patrick Williams <> | Subject | Re: [PATCH 0/2] pinctl: armada-37xx: fix for pins 32+ |
| |
On Tue, Jun 25, 2019 at 03:38:59PM +0200, Gregory CLEMENT wrote: > First you can add my > Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Thanks for the review Gregory.
> Then as the second patch is a fix, you should add the fix tag: "Fixes: > 5715092a458c ("pinctrl: armada-37xx: Add gpio support") " as well as the > 'CC: <stable@vger.kernel.org>" tags. > > But your change in the first patch made this second patch more difficult > to backport. > ... > Maybe you could change the order of those 2 patches?
Good points. Will do both.
> Actually, when I wrote "_update_reg" I was thinking to the update of the > variable, whereas with a function named "_calculate_reg" I am expecting > having the result as a return of the function.
Understand. I can see the ambiguity in both names. How about "_update_reg_offset"?
> Thanks, > > Gregory > -- - Patrick
| |