| From | Phong Tran <> | Subject | [PATCH V3 05/15] ARM: footbridge: cleanup cppcheck shifting error | Date | Tue, 25 Jun 2019 11:03:46 +0700 |
| |
There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement.
Signed-off-by: Phong Tran <tranmanphong@gmail.com> --- arch/arm/mach-footbridge/dc21285.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-footbridge/dc21285.c b/arch/arm/mach-footbridge/dc21285.c index 8b81a17f675d..edea41e0256f 100644 --- a/arch/arm/mach-footbridge/dc21285.c +++ b/arch/arm/mach-footbridge/dc21285.c @@ -230,7 +230,7 @@ static irqreturn_t dc21285_parity_irq(int irq, void *dev_id) printk("\n"); cmd = *CSR_PCICMD & 0xffff; - *CSR_PCICMD = cmd | 1 << 31; + *CSR_PCICMD = cmd | BIT(31); /* * back off this interrupt -- 2.11.0
|