Messages in this thread | | | Date | Tue, 25 Jun 2019 13:56:31 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v3 5/7] mfd: ioc3: Add driver for SGI IOC3 chip |
| |
On Tue, 25 Jun 2019, Thomas Bogendoerfer wrote:
> On Thu, Jun 13, 2019 at 07:06:31PM +0200, Thomas Bogendoerfer wrote: > > SGI IOC3 chip has integrated ethernet, keyboard and mouse interface. > > It also supports connecting a SuperIO chip for serial and parallel > > interfaces. IOC3 is used inside various SGI systemboards and add-on > > cards with different equipped external interfaces. > > > > Support for ethernet and serial interfaces were implemented inside > > the network driver. This patchset moves out the not network related > > parts to a new MFD driver, which takes care of card detection, > > setup of platform devices and interrupt distribution for the subdevices. > > > > Serial portion: Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de> > > --- > > arch/mips/include/asm/sn/ioc3.h | 345 +++---- > > arch/mips/sgi-ip27/ip27-timer.c | 20 - > > drivers/mfd/Kconfig | 13 + > > drivers/mfd/Makefile | 1 + > > drivers/mfd/ioc3.c | 683 +++++++++++++ > > Lee, > > can you give me an indication, if the MFD changes are ok now > or if I need to improve it further.
I will do, when I get to them.
My review list currently runs into the 50s.
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |