lkml.org 
[lkml]   [2019]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v12 5/5] can: m_can: Fix checkpatch issues on existing code
From
Date
Hi,

On 09/05/19 9:41 PM, Dan Murphy wrote:
> Fix checkpatch issues found during the m_can framework creation.
> The code the issues were in, was in untouched code and these
> changes should be done separately as to not be confused with the
> framework changes.
>
> Fix these 3 check issues:
> CHECK: Unnecessary parentheses around 'cdev->can.state != CAN_STATE_ERROR_WARNING'
> if (psr & PSR_EW &&
> (cdev->can.state != CAN_STATE_ERROR_WARNING)) {
>
> CHECK: Unnecessary parentheses around 'cdev->can.state != CAN_STATE_ERROR_PASSIVE'
> if ((psr & PSR_EP) &&
> (cdev->can.state != CAN_STATE_ERROR_PASSIVE)) {
>
> CHECK: Unnecessary parentheses around 'cdev->can.state != CAN_STATE_BUS_OFF'
> if ((psr & PSR_BO) &&
> (cdev->can.state != CAN_STATE_BUS_OFF)) {
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>

Acked-by: Faiz Abbas <faiz_abbas@ti.com>

Thanks,
Faiz

\
 
 \ /
  Last update: 2019-06-25 11:25    [W:0.107 / U:33.260 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site