lkml.org 
[lkml]   [2019]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt
Date


On 25.06.2019 11:55, Peter Rosin wrote:

>
> On 2019-06-25 10:05, Eugen.Hristev@microchip.com wrote:
>> From: Eugen Hristev <eugen.hristev@microchip.com>
>>
>> Add binding specification for analogic filter inside the i2c controller
>
> s/analogic/the analog/
>
>> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
>> ---
>> Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
>> index 8268595..20d334c 100644
>> --- a/Documentation/devicetree/bindings/i2c/i2c-at91.txt
>> +++ b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
>> @@ -23,6 +23,9 @@ Optional properties:
>> - enable-dig-filt: Enable the built-in digital filter on the i2c lines,
>> specifically required depending on the hardware PCB/board and if the
>> version of the controller includes it.
>> +- enable-ana-filt: Enable the built-in analogic filter on the i2c lines,
>> + specifically required depending on the hardware PCB/board and if the
>> + version of the controller includes it.
>> - Child nodes conforming to i2c bus binding
>>
>> Examples :
>> @@ -60,6 +63,7 @@ i2c0: i2c@f8034600 {
>> atmel,fifo-size = <16>;
>> i2c-sda-hold-time-ns = <336>;
>> enable-dig-filt;
>> + enable-ana-filt;
>
> Perhaps
>
> microchip,digital-filter;
> microchip,analog-filter;
>
> ?

Hi Peter,

Thanks for reviewing. The name of the property does not matter much to
me, and we have properties prefixed with vendor, and some are not.

@Alexandre Belloni: which name you think it's best ?

Eugen

>
> Cheers,
> Peter
>
>>
>> wm8731: wm8731@1a {
>> compatible = "wm8731";
>>
>
\
 
 \ /
  Last update: 2019-06-25 11:15    [W:0.069 / U:0.316 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site