lkml.org 
[lkml]   [2019]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V3 01/15] arm: perf: cleanup cppcheck shifting error
    Date
    There is error from cppcheck tool
    "Shifting signed 32-bit value by 31 bits is undefined behaviour errors"
    change to use BIT() marco for improvement.

    Signed-off-by: Phong Tran <tranmanphong@gmail.com>
    ---
    arch/arm/kernel/perf_event_v7.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/arch/arm/kernel/perf_event_v7.c b/arch/arm/kernel/perf_event_v7.c
    index a4fb0f8b8f84..2924d7910b10 100644
    --- a/arch/arm/kernel/perf_event_v7.c
    +++ b/arch/arm/kernel/perf_event_v7.c
    @@ -697,9 +697,9 @@ static struct attribute_group armv7_pmuv2_events_attr_group = {
    /*
    * Event filters for PMUv2
    */
    -#define ARMV7_EXCLUDE_PL1 (1 << 31)
    -#define ARMV7_EXCLUDE_USER (1 << 30)
    -#define ARMV7_INCLUDE_HYP (1 << 27)
    +#define ARMV7_EXCLUDE_PL1 BIT(31)
    +#define ARMV7_EXCLUDE_USER BIT(30)
    +#define ARMV7_INCLUDE_HYP BIT(27)

    /*
    * Secure debug enable reg
    --
    2.11.0
    \
     
     \ /
      Last update: 2019-06-25 06:05    [W:4.533 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site