lkml.org 
[lkml]   [2019]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state
Hi Greg,

On Mon, 17 Jun 2019 at 05:41, Joel Stanley <joel@jms.id.au> wrote:
>
> On Mon, 17 Jun 2019 at 02:09, Alistair Popple <alistair@popple.id.au> wrote:
> >
> > On Monday, 21 January 2019 11:15:58 AM AEST Eddie James wrote:
> > > SBE fifo operations should be allowed while the SBE is in any of the
> > > "IPL" states. Operations should succeed in this state.
> > >
> > > Signed-off-by: Eddie James <eajames@linux.ibm.com>
> >
> > This fixed the problem I was having trying to issue istep operations to the
> > SBE.
> >
> > Tested-by: Alistair Popple <alistair@popple.id.au>
>
> This one slipped through the cracks.
>
> Fixes: 9f4a8a2d7f9d fsi/sbefifo: Add driver for the SBE FIFO
> Reviewed-by: Joel Stanley <joel@jsm.id.au>
>
> Greg, can you please queue this one up for 5.3?

Ping?

>
> Cheers,
>
> Joel
>
> > > ---
> > > drivers/fsi/fsi-sbefifo.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> > > index c7d13ac..f7665b3 100644
> > > --- a/drivers/fsi/fsi-sbefifo.c
> > > +++ b/drivers/fsi/fsi-sbefifo.c
> > > @@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo
> > > *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >>
> > > CFAM_SBM_SBE_STATE_SHIFT) { case SBE_STATE_UNKNOWN:
> > > return -ESHUTDOWN;
> > > + case SBE_STATE_DMT:
> > > + return -EBUSY;
> > > case SBE_STATE_IPLING:
> > > case SBE_STATE_ISTEP:
> > > case SBE_STATE_MPIPL:
> > > - case SBE_STATE_DMT:
> > > - return -EBUSY;
> > > case SBE_STATE_RUNTIME:
> > > case SBE_STATE_DUMP: /* Not sure about that one */
> > > break;
> >
> >

\
 
 \ /
  Last update: 2019-06-25 06:36    [W:0.040 / U:18.868 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site