Messages in this thread | | | Date | Tue, 25 Jun 2019 08:51:07 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH v13 06/13] irqchip: Add irq-ingenic-tcu driver |
| |
On Tue, 25 Jun 2019, Paul Cercueil wrote:
> --- /dev/null > +++ b/drivers/irqchip/irq-ingenic-tcu.c > @@ -0,0 +1,182 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * JZ47xx SoCs TCU IRQ driver > + * Copyright (C) 2019 Paul Cercueil <paul@crapouillou.net> > + */
Nothing to complain here. Just a few nit picks.
> + > +struct ingenic_tcu { > + struct regmap *map; > + struct clk *clk; > + > + struct irq_domain *domain; > + unsigned int nb_parent_irqs; > + u32 parent_irqs[3]; > +};
In case you respin this then please format it tabular:
struct ingenic_tcu { struct regmap *map; struct clk *clk; struct irq_domain *domain; unsigned int nb_parent_irqs; u32 parent_irqs[3]; };
It's simpler to parse that way, at least for me :)
Anyway:
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
| |