lkml.org 
[lkml]   [2019]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC/RFT 05/14] soc: amlogic: meson-clk-measure: protect measure with a mutex
Date
Quoting Neil Armstrong (2019-06-20 08:00:04)
> In order to protect clock measuring when multiple process asks for
> a mesure, protect the main measure function with mutexes.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> drivers/soc/amlogic/meson-clk-measure.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/amlogic/meson-clk-measure.c b/drivers/soc/amlogic/meson-clk-measure.c
> index 19d4cbc93a17..c470e24f1dfa 100644
> --- a/drivers/soc/amlogic/meson-clk-measure.c
> +++ b/drivers/soc/amlogic/meson-clk-measure.c
> @@ -11,6 +11,8 @@
> #include <linux/debugfs.h>
> #include <linux/regmap.h>
>
> +static DEFINE_MUTEX(measure_lock);
> +
> #define MSR_CLK_DUTY 0x0
> #define MSR_CLK_REG0 0x4
> #define MSR_CLK_REG1 0x8
> @@ -360,6 +362,10 @@ static int meson_measure_id(struct meson_msr_id *clk_msr_id,
> unsigned int val;
> int ret;
>
> + ret = mutex_lock_interruptible(&measure_lock);

Why interruptible?

> + if (ret)
> + return ret;
> +
> regmap_write(priv->regmap, MSR_CLK_REG0, 0);
>
> /* Set measurement duration */

\
 
 \ /
  Last update: 2019-06-25 22:28    [W:0.099 / U:156.284 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site