[lkml]   [2019]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v1 3/6] mm: Use zone and order instead of free area in free_list manipulators
On 6/19/19 3:33 PM, Alexander Duyck wrote:
> - move_to_free_area(page, &zone->free_area[order], migratetype);
> + move_to_free_area(page, zone, order, migratetype);

This certainly looks nicer. But the naming is a bit goofy now because
you're talking about free areas, but there's no free area to be seen.
If anything, isn't it moving to a free_list[]? It's actually going to
zone->free_area[]->free_list[], so the free area seems rather
inconsequential in the entire thing. The (zone/order/migratetype)
combination specifies a free_list[] not a free area anyway.

 \ /
  Last update: 2019-06-25 20:37    [W:0.177 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site