lkml.org 
[lkml]   [2019]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] vfs: create a generic checking function for FS_IOC_SETFLAGS
On Tue, Jun 25, 2019 at 07:12:54PM +0200, David Sterba wrote:
> On Fri, Jun 21, 2019 at 04:56:21PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Create a generic checking function for the incoming FS_IOC_SETFLAGS flag
> > values so that we can standardize the implementations that follow ext4's
> > flag values.
>
> I checked a few samples what's the type of the flags, there are unsigned
> types while the proposed VFS functions take signed type.
>
> > +int vfs_ioc_setflags_check(struct inode *inode, int oldflags, int flags);
>
> Specifically ext4 uses unsigned type and his was the original API that
> got copied so I'd think that it should unsigned everywhere.

Yeah, I'll change it.

> > fs/btrfs/ioctl.c | 13 +++++--------
>
> For the btrfs bits
>
> Acked-by: David Sterba <dsterba@suse.com>
>
> and besides the signedness, the rest of the changes look good to me.

Thanks for the look around! I'll have a new revision with all changes
out by the end of the day. :)

--D

\
 
 \ /
  Last update: 2019-06-25 20:19    [W:0.069 / U:0.608 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site