Messages in this thread | | | From | Joel Stanley <> | Date | Tue, 25 Jun 2019 04:03:04 +0000 | Subject | Re: [PATCH v2] lib/mpi: fix build with clang |
| |
On Fri, 21 Jun 2019 at 19:56, Mathieu Malaterre <malat@debian.org> wrote: > > Remove superfluous casts on output operands to avoid warnings on the > following macros: > > * add_ssaaaa(sh, sl, ah, al, bh, bl) > * sub_ddmmss(sh, sl, ah, al, bh, bl) > * umul_ppmm(ph, pl, m0, m1) > > Special care has been taken to keep the diff as minimal as possible from > the original header file `longlong.h` from gcc, only importing the > minimal change to make the compilation with clang pass.
> Suggested-by: Joel Stanley <joel@jms.id.au> > Cc: Segher Boessenkool <segher@kernel.crashing.org> > Signed-off-by: Mathieu Malaterre <malat@debian.org> > --- > v2: Instead of passing compat flag to clang to behave as gcc, remove the superfluous cast
Thanks, I checked your patch against GCC's longlong.h and it looks good.
Reviewed-by: Joel Stanley <joel@jms.id.au>
Cheers,
Joel
| |