[lkml]   [2019]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
SubjectRe: [PATCH 2/3] module: Fix up module_notifier return values.
----- On Jun 24, 2019, at 5:18 AM, Peter Zijlstra wrote:

> While auditing all module notifiers I noticed a whole bunch of fail
> wrt the return value. Notifiers have a 'special' return semantics.
> Cc: Robert Richter <>
> Cc: Steven Rostedt <>
> Cc: Ingo Molnar <>
> Cc: Alexei Starovoitov <>
> Cc: Daniel Borkmann <>
> Cc: Martin KaFai Lau <>
> Cc: Song Liu <>
> Cc: Yonghong Song <>
> Cc: Mathieu Desnoyers <>
> Cc: "Paul E. McKenney" <>
> Cc: "Joel Fernandes (Google)" <>
> Cc: Ard Biesheuvel <>
> Cc: Thomas Gleixner <>
> Cc:
> Cc:
> Cc:
> Cc:
> Signed-off-by: Peter Zijlstra (Intel) <>

Thanks Peter for looking into this, especially considering your
endless love for kernel modules! ;)

It's not directly related to your changes, but I notice that
appears to leak memory. Am I missing something ?

With respect to your changes:
Reviewed-by: Mathieu Desnoyers <>

I have a similar erroneous module notifier return value pattern
in lttng-modules as well. I'll go fix it right away. CCing
Frank Eigler from SystemTAP which AFAIK use a copy of
lttng-tracepoint.c in their project, which should be fixed
as well. I'm pasting the lttng-modules fix below.




commit 5eac9d146a7d947f0f314c4f7103c92cbccaeaf3
Author: Mathieu Desnoyers <>
Date: Mon Jun 24 09:43:45 2019 -0400

Fix: lttng-tracepoint module notifier should return NOTIFY_OK

Module notifiers should return NOTIFY_OK on success rather than the
value 0. The return value 0 does not seem to have any ill side-effects
in the notifier chain caller, but it is preferable to respect the API
requirements in case this changes in the future.

Notifiers can encapsulate a negative errno value with
notifier_from_errno(), but this is not needed by the LTTng tracepoint

The approach taken in this notifier is to just print a console warning
on error, because tracing failure should not prevent loading a module.
So we definitely do not want to stop notifier iteration. Returning
an error without stopping iteration is not really that useful, because
only the return value of the last callback is returned to notifier chain

Signed-off-by: Mathieu Desnoyers <>

diff --git a/lttng-tracepoint.c b/lttng-tracepoint.c
index bbb2c7a4..8298b397 100644
--- a/lttng-tracepoint.c
+++ b/lttng-tracepoint.c
@@ -256,7 +256,7 @@ int lttng_tracepoint_coming(struct tp_module *tp_mod)
- return 0;
+ return NOTIFY_OK;


Mathieu Desnoyers
EfficiOS Inc.

 \ /
  Last update: 2019-06-24 16:01    [W:0.077 / U:3.084 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site