lkml.org 
[lkml]   [2019]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2 04/15] ARM: exynos: cleanup cppcheck shifting error
    On Mon, Jun 24, 2019 at 08:50:54PM +0700, Phong Tran wrote:
    > [arch/arm/mach-exynos/suspend.c:288]: (error) Shifting signed 32-bit
    > value by 31 bits is undefined behaviour
    >
    > Signed-off-by: Phong Tran <tranmanphong@gmail.com>
    > ---
    > arch/arm/mach-exynos/suspend.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
    > index be122af0de8f..b6a73dc5bde4 100644
    > --- a/arch/arm/mach-exynos/suspend.c
    > +++ b/arch/arm/mach-exynos/suspend.c
    > @@ -285,7 +285,7 @@ static void exynos_pm_set_wakeup_mask(void)
    > * Set wake-up mask registers
    > * EXYNOS_EINT_WAKEUP_MASK is set by pinctrl driver in late suspend.
    > */
    > - pmu_raw_writel(exynos_irqwake_intmask & ~(1 << 31), S5P_WAKEUP_MASK);
    > + pmu_raw_writel(exynos_irqwake_intmask & ~(BIT(31)), S5P_WAKEUP_MASK);

    Parens around BIT() are no longer required.

    > }
    >
    > static void exynos_pm_enter_sleep_mode(void)
    > --
    > 2.11.0
    >
    >

    --
    RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
    FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
    According to speedtest.net: 11.9Mbps down 500kbps up

    \
     
     \ /
      Last update: 2019-06-24 15:59    [W:3.073 / U:1.868 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site