lkml.org 
[lkml]   [2019]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] mtd: spinand: read return badly if the last page has bitflips
From
Date
OK, thanks for your reviewing. I will resend right now.

On 2019/6/24 PM3:37, Schrempf Frieder wrote:
> On 20.06.19 03:00, liaoweixiong wrote:
>> In case of the last page containing bitflips (ret > 0),
>> spinand_mtd_read() will return that number of bitflips for the last
>> page. But to me it looks like it should instead return max_bitflips like
>> it does when the last page read returns with 0.
>>
>> Signed-off-by: liaoweixiong <liaoweixiong@allwinnertech.com>
>
> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> This should probably be resent with the following tags:
>
> Cc: stable@vger.kernel.org
> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI
> NANDs")
>
>> ---
>> drivers/mtd/nand/spi/core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
>> index 556bfdb..6b9388d 100644
>> --- a/drivers/mtd/nand/spi/core.c
>> +++ b/drivers/mtd/nand/spi/core.c
>> @@ -511,12 +511,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from,
>> if (ret == -EBADMSG) {
>> ecc_failed = true;
>> mtd->ecc_stats.failed++;
>> - ret = 0;
>> } else {
>> mtd->ecc_stats.corrected += ret;
>> max_bitflips = max_t(unsigned int, max_bitflips, ret);
>> }
>>
>> + ret = 0;
>> ops->retlen += iter.req.datalen;
>> ops->oobretlen += iter.req.ooblen;
>> }

--
liaoweixiong

\
 
 \ /
  Last update: 2019-06-24 14:11    [W:0.068 / U:11.864 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site