[lkml]   [2019]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 13/28] drivers: Introduce class_find_device_by_of_node() helper
Hi Peter,

On 22/06/2019 06:25, Peter Rosin wrote:
> On 2019-06-14 19:54, Suzuki K Poulose wrote:
>> Add a wrapper to class_find_device() to search for a device
>> by the of_node pointer, reusing the generic match function.
>> Also convert the existing users to make use of the new helper.
>> Cc: Alan Tull <>
>> Cc: Moritz Fischer <>
>> Cc:
>> Cc: Peter Rosin <>
>> Cc: Mark Brown <>
>> Cc: Florian Fainelli <>
>> Cc: Heiner Kallweit <>
>> Cc: "David S. Miller" <>
>> Cc: Andrew Lunn <>
>> Cc: Liam Girdwood <>
>> Cc: Greg Kroah-Hartman <>
>> Cc: "Rafael J. Wysocki" <>
>> Cc: Jiri Slaby <>
>> Acked-by: Mark Brown <>
>> Reviewed-by: Andrew Lunn <>
>> Reviewed-by: Peter Rosin <>
> Whoooa! I reviewed only the drivers/mux/core.c changes when this was done
> in a series of much smaller patches. This tag makes it seem as if I have
> reviewed the whole thing, which I had not done when you added this tag out
> of the blue.

Apologies for the surprise. The patch was simply squashed with the change that
introduced the "helper" to better aid the reviewers, based on suggestions on the
list. I kept your tags, only because there were no changes, but some additional
context on the core driver.

> Now, this stuff is trivial and by now I have looked at the other files
> and it all seems simple enough. So, you can keep the tag, but it is NOT
> ok to handle tags like you have done here.

Sure, I will keep that in mind.


 \ /
  Last update: 2019-06-24 10:34    [W:0.040 / U:5.152 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site