lkml.org 
[lkml]   [2019]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/4] block: add zone open, close and finish support
    From
    Date
    On 6/21/19 6:07 AM, Matias Bjørling wrote:
    > diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
    > index 95202f80676c..067ef9242275 100644
    > --- a/include/linux/blk_types.h
    > +++ b/include/linux/blk_types.h
    > @@ -284,13 +284,20 @@ enum req_opf {
    > REQ_OP_DISCARD = 3,
    > /* securely erase sectors */
    > REQ_OP_SECURE_ERASE = 5,
    > - /* reset a zone write pointer */
    > - REQ_OP_ZONE_RESET = 6,
    > /* write the same sector many times */
    > REQ_OP_WRITE_SAME = 7,
    > /* write the zero filled sector many times */
    > REQ_OP_WRITE_ZEROES = 9,
    >
    > + /* reset a zone write pointer */
    > + REQ_OP_ZONE_RESET = 16,
    > + /* Open zone(s) */
    > + REQ_OP_ZONE_OPEN = 17,
    > + /* Close zone(s) */
    > + REQ_OP_ZONE_CLOSE = 18,
    > + /* Finish zone(s) */
    > + REQ_OP_ZONE_FINISH = 19,
    > +
    > /* SCSI passthrough using struct scsi_request */
    > REQ_OP_SCSI_IN = 32,
    > REQ_OP_SCSI_OUT = 33,
    > @@ -375,6 +382,22 @@ static inline void bio_set_op_attrs(struct bio *bio, unsigned op,
    > bio->bi_opf = op | op_flags;
    > }

    Are the new operation types ever passed to op_is_write()? The definition
    of that function is as follows:

    static inline bool op_is_write(unsigned int op)
    {
    return (op & 1);
    }

    \
     
     \ /
      Last update: 2019-06-24 21:44    [W:2.676 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site