Messages in this thread | | | Date | Mon, 24 Jun 2019 21:04:41 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v1] Increase MAX_NR_CPUS and MAX_CACHES |
| |
On Mon, Jun 24, 2019 at 03:50:58PM -0300, Arnaldo Carvalho de Melo wrote:
SNIP
> > diff --git a/samples/bpf/map_perf_test_user.c b/samples/bpf/map_perf_test_user.c > > index fe5564bff39b..da3c101ca776 100644 > > --- a/samples/bpf/map_perf_test_user.c > > +++ b/samples/bpf/map_perf_test_user.c > > @@ -22,7 +22,7 @@ > > #include "bpf_load.h" > > > > #define TEST_BIT(t) (1U << (t)) > > -#define MAX_NR_CPUS 1024 > > +#define MAX_NR_CPUS 2048 > > > > static __u64 time_get_ns(void) > > { > > diff --git a/tools/perf/perf.h b/tools/perf/perf.h > > index 711e009381ec..74d0124d38f3 100644 > > --- a/tools/perf/perf.h > > +++ b/tools/perf/perf.h > > @@ -26,7 +26,7 @@ static inline unsigned long long rdclock(void) > > } > > > > #ifndef MAX_NR_CPUS > > -#define MAX_NR_CPUS 1024 > > +#define MAX_NR_CPUS 2048 > > #endif > > > > extern const char *input_name; > > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c > > index 06ddb6618ef3..abc9c2145efe 100644 > > --- a/tools/perf/util/header.c > > +++ b/tools/perf/util/header.c > > @@ -1121,7 +1121,7 @@ static int build_caches(struct cpu_cache_level caches[], u32 size, u32 *cntp) > > return 0; > > } > > > > -#define MAX_CACHES 2000 > > +#define MAX_CACHES (MAX_NR_CPUS * 4)
maybe we should re-do this via dynamic allocation ;-) but for now it's ok
would be nice to have perf change separated, anyway for perf part:
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks, jirka
| |