lkml.org 
[lkml]   [2019]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 00/15] cleanup cppcheck signed shifting errors
On Mon, Jun 24, 2019 at 05:27:43PM +0200, Peter Zijlstra wrote:
> On Mon, Jun 24, 2019 at 08:50:50PM +0700, Phong Tran wrote:
> > There are errors with cppcheck
> >
> > "Shifting signed 32-bit value by 31 bits is undefined behaviour errors"
>
> As I've already told you; your checker is bad. That is not in face

Bah, fact, typing hard.

> undefined behaviour in the kernel.
>
> That's not to say you shouldn't clean up the code, but don't give broken
> checkout output as a reason.

\
 
 \ /
  Last update: 2019-06-24 17:29    [W:0.136 / U:8.868 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site