Messages in this thread | | | Subject | Re: [PATCH 2/5] lib: logic_pio: Add logic_pio_unregister_range() | From | John Garry <> | Date | Fri, 21 Jun 2019 15:19:32 +0100 |
| |
On 21/06/2019 14:49, Bjorn Helgaas wrote: >> --- a/lib/logic_pio.c >> > +++ b/lib/logic_pio.c >> > @@ -56,7 +56,7 @@ int logic_pio_register_range(struct logic_pio_hwaddr *new_range) >> > /* for MMIO ranges we need to check for overlap */ >> > if (start >= range->hw_start + range->size || >> > end < range->hw_start) { >> > - mmio_sz += range->size; >> > + mmio_sz = range->io_start + range->size;
Hi Bjorn,
> Should this be renamed to something like "mmio_end"? Computing a > "size" as "start + size" looks wrong at first glance. The code overall > probably makes sense, but maybe breaking this out as a separate "avoid > overlaps" patch that renames "mmio_sz" might make it clearer.
I agree with the renaming to "mmio_end". I can split it out into another patch also.
Thanks, John
> >> > } else { >> > ret = -EFAULT; >> > goto end_register;
| |