Messages in this thread Patch in this message | | | From | Yannick FERTRE <> | Subject | Re: [PATCH 1/3] drm/stm: drv: fix suspend/resume | Date | Fri, 21 Jun 2019 14:01:31 +0000 |
| |
Hi Emil,
The msm driver tests the return value & set state to NULL if no error is detected.
the ltdc driver tests the return value & force to suspend if an error is detected.
It's not exactly the same.
Best regards
-- Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270 Microcontrollers and Digital ICs Group | Microcontrolleurs Division
On 6/20/19 7:12 PM, Emil Velikov wrote: > Hi Yannick, > > On Mon, 17 Jun 2019 at 08:18, Yannick Fertré <yannick.fertre@st.com> wrote: > >> @@ -155,15 +154,17 @@ static __maybe_unused int drv_resume(struct device *dev) >> struct ltdc_device *ldev = ddev->dev_private; >> int ret; >> >> + if (WARN_ON(!ldev->suspend_state)) >> + return -ENOENT; >> + >> pm_runtime_force_resume(dev); >> ret = drm_atomic_helper_resume(ddev, ldev->suspend_state); >> - if (ret) { >> + if (ret) > Hmm the msm driver uses !ret here. Suspecting that you want the same, > although I haven't checked in detail. > > HTH > -Emil -- Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270 Microcontrollers and Digital ICs Group | Microcontrolleurs Division | |