lkml.org 
[lkml]   [2019]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/16] mm: lift the x86_32 PAE version of gup_get_pte to common code
    On Tue, Jun 11, 2019 at 04:40:49PM +0200, Christoph Hellwig wrote:
    > The split low/high access is the only non-READ_ONCE version of
    > gup_get_pte that did show up in the various arch implemenations.
    > Lift it to common code and drop the ifdef based arch override.
    >
    > Signed-off-by: Christoph Hellwig <hch@lst.de>
    > ---
    > arch/x86/Kconfig | 1 +
    > arch/x86/include/asm/pgtable-3level.h | 47 ------------------------
    > arch/x86/kvm/mmu.c | 2 +-
    > mm/Kconfig | 3 ++
    > mm/gup.c | 51 ++++++++++++++++++++++++---
    > 5 files changed, 52 insertions(+), 52 deletions(-)

    Yep, the sh and mips conversions look right too.

    Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>

    > diff --git a/mm/Kconfig b/mm/Kconfig
    > index f0c76ba47695..fe51f104a9e0 100644
    > --- a/mm/Kconfig
    > +++ b/mm/Kconfig
    > @@ -762,6 +762,9 @@ config GUP_BENCHMARK
    >
    > See tools/testing/selftests/vm/gup_benchmark.c
    >
    > +config GUP_GET_PTE_LOW_HIGH
    > + bool
    > +

    The config name seems a bit out of place though, should it be prefixed
    with GENERIC_ or ARCH_?

    Jason

    \
     
     \ /
      Last update: 2019-06-21 15:46    [W:5.444 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site