Messages in this thread | | | Subject | Re: [PATCH v2 3/8] staging: erofs: move per-CPU buffers implementation to utils.c | From | Gao Xiang <> | Date | Fri, 21 Jun 2019 16:32:31 +0800 |
| |
Hi Chao,
On 2019/6/21 15:57, Chao Yu wrote: > On 2019/6/21 0:07, Gao Xiang wrote: >> +static inline void *erofs_get_pcpubuf(unsigned int pagenr) >> +{ >> + return ERR_PTR(-ENOTSUPP); >> +} > > [snip] > >> + percpu_data = erofs_get_pcpubuf(0); > > If erofs_get_pcpubuf may return error once EROFS_PCPUBUF_NR_PAGES equals to > zero, we'd better to check the error number here.
decompressor.c will be built-in only when decompression is enabled and if decompression is enabled EROFS_PCPUBUF_NR_PAGES is not zero.
But I think introducing some error handling logic is not bad as well. Will fix in the next version.
Thanks, Gao Xiang
> > Thanks, >
| |