Messages in this thread | | | Subject | Re: Coccinelle: Add a SmPL script for the reconsideration of redundant dev_err() calls | From | Markus Elfring <> | Date | Thu, 20 Jun 2019 21:02:50 +0200 |
| |
>> +@display depends on context@ >> +expression e; >> +@@ >> + e = devm_ioremap_resource(...); >> + if (IS_ERR(e)) >> + { >> +* dev_err(...); >> + return (...); >> + } > > Why do you assume that there is exactly one dev_err and one return after > the test?
I propose to start with the addition of a simple source code search pattern. Would you prefer to clarify a more advanced approach?
>> +@script:python to_do depends on org@ >> +p << or.p; >> +@@ >> +coccilib.org.print_todo(p[0], >> + "WARNING: An error message is probably not needed here because the previously called function contains appropriate error reporting.") > > "the previously called function" would be better as "devm_ioremap_resource".
Would you like to get the relevant function name dynamically determined?
Regards, Markus
| |