lkml.org 
[lkml]   [2019]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RESEND, PATCH 1/4] net: stmmac: dwmac-mediatek: enable Ethernet power domain
From
From: Biao Huang <biao.huang@mediatek.com>
Date: Thu, 30 May 2019 17:43:15 +0800

> @@ -364,6 +371,15 @@ static int mediatek_dwmac_probe(struct platform_device *pdev)
> return 0;
> }
>
> +static int mediatek_dwmac_remove(struct platform_device *pdev)
> +{
> + int ret;
> +
> + ret = stmmac_pltfr_remove(pdev);
> +
> + return ret;
> +}
> +
> static const struct of_device_id mediatek_dwmac_match[] = {
> { .compatible = "mediatek,mt2712-gmac",
> .data = &mt2712_gmac_variant },
> @@ -374,7 +390,7 @@ static int mediatek_dwmac_probe(struct platform_device *pdev)
>
> static struct platform_driver mediatek_dwmac_driver = {
> .probe = mediatek_dwmac_probe,
> - .remove = stmmac_pltfr_remove,
> + .remove = mediatek_dwmac_remove,
> .driver = {
> .name = "dwmac-mediatek",
> .pm = &stmmac_pltfr_pm_ops,

This half of your patch has no effect and seems completely unnecessary.

Please remove it.

\
 
 \ /
  Last update: 2019-06-02 22:02    [W:0.046 / U:0.736 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site