lkml.org 
[lkml]   [2019]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] SPDX update for 5.2-rc3 - round 2
On Sun, Jun 02, 2019 at 09:03:46PM +0900, Masahiro Yamada wrote:
> On Sun, Jun 2, 2019 at 4:17 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > The following changes since commit 2f4c53349961c8ca480193e47da4d44fdb8335a8:
> >
> > Merge tag 'spdx-5.2-rc3-1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core (2019-05-31 08:34:32 -0700)
> >
> > are available in the Git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/spdx-5.2-rc3-2
> >
> > for you to fetch changes up to 8e82fe2ab65a80b1526b285c661ab88cc5891e3a:
> >
> > treewide: fix typos of SPDX-License-Identifier (2019-06-01 18:29:58 +0200)
> >
> > ----------------------------------------------------------------
> > SPDX fixes for 5.2-rc3, round 2
> >
> > Here are just two small patches, that fix up some found SPDX identifier
> > issues.
> >
> > The first patch fixes an error in a previous SPDX fixup patch, that
> > causes build errors when doing 'make clean' on the tree (the fact that
> > almost no one noticed it reflects the fact that kernel developers don't
> > like doing that option very often...)
>
> This paragraph is not precise.
>
> Not only "make clean", but also the normal build is broken.
> In fact, ARCH=arm allmodconfig is broken.
>
>
> $ make -j8 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- allmodconfig
> [ snip ]
> $ make -j8 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
> [ snip ]
> drivers/crypto/ux500/cryp/Makefile:5: *** missing separator. Stop.
> make[3]: *** [scripts/Makefile.build;489: drivers/crypto/ux500/cryp] Error 2
> make[2]: *** [scripts/Makefile.build;489: drivers/crypto/ux500] Error 2
> make[1]: *** [scripts/Makefile.build;489: drivers/crypto] Error 2
> make[1]: *** Waiting for unfinished jobs....
>
>
>
> The 0-day bot should check allmodconfig for all arches,
> but surprisingly it was not caught before the merge.

Ah, good catch, odd that 0-day missed it. Maybe it is not building
32bit builds these days :(

> > The second patch fixes up a number of places in the tree where people
> > mistyped the string "SPDX-License-Identifier". Given that people can
> > not even type their own name all the time without mistakes, this was
> > bound to happen, and odds are, we will have to add some type of check
> > for this to checkpatch.pl to catch this happening in the future.
>
> checkpatch.pl already warns
> "Missing or malformed SPDX-License-Identifier tag"
> unless correctly typed "SPDX-License-Identifier" is found in the file.
>
> No more check is needed for this, I think.

Ok, thanks, I thought it was not caught which is why it snuck in.

> Not all developers run scripts/checkpatch.pl before patch submission.
> Not all maintainers run scripts/checkpatch.pl before commit.

Very true :(

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-06-02 19:17    [W:0.062 / U:8.604 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site