lkml.org 
[lkml]   [2019]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/9] staging: rtl8712: Fixed CamelCase rename ImrContent to imr_content
On Sun, Jun 02, 2019 at 03:55:30PM +0530, Deepak Mishra wrote:
> This patch renames CamelCase ImrContent to imr_content in struct _adapter and related
> files drv_types.h, rtl871x_mp_ioctl.c, rtl871x_pwrctrl.h
>
> CHECK: Avoid CamelCase: <ImrContent>
>
> Signed-off-by: Deepak Mishra <linux.dkm@gmail.com>
> ---
> drivers/staging/rtl8712/drv_types.h | 2 +-
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 2 +-
> drivers/staging/rtl8712/rtl871x_pwrctrl.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> index 9ae86631fa8b..89ebb5a49d25 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -149,7 +149,7 @@ struct _adapter {
> bool surprise_removed;
> bool suspended;
> u32 IsrContent;
> - u32 ImrContent;
> + u32 imr_content;
> u8 EepromAddressSize;
> u8 hw_init_completed;
> struct task_struct *cmdThread;

This field is never used? Why not just delete it?

> diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
> index 588346da1412..4cf9d3afd2c5 100644
> --- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
> +++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
> @@ -665,7 +665,7 @@ uint oid_rt_pro_write_register_hdl(struct oid_par_priv *poid_par_priv)
> if ((status == RNDIS_STATUS_SUCCESS) &&
> (RegRWStruct->offset == HIMR) &&
> (RegRWStruct->width == 4))
> - Adapter->ImrContent = RegRWStruct->value;
> + Adapter->imr_content = RegRWStruct->value;

It is set and never read? Please remove.

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-06-02 19:12    [W:0.099 / U:4.632 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site