Messages in this thread | | | From | "Valdis Klētnieks" <> | Subject | checkpatch query regarding .c and .h files.. | Date | Sun, 02 Jun 2019 13:02:44 -0400 |
| |
scripts/checkpatch.pl contains this code near line 3070:
if ($realfile =~ /\.(h|s|S)$/) { $comment = '/*'; } elsif ($realfile =~ /\.(c|dts|dtsi)$/) { $comment = '//'; } elsif (($checklicenseline == 2) || $realfile =~ /\.(sh|pl|py|awk|tc)$/) { $comment = '#'; } elsif ($realfile =~ /\.rst$/) { $comment = '..'; }
Was there a specific reason why .h files have /* */ and .c files have C89 // on the SPDX comment line?
Would anybody like a patch that fixed checkpatch to allow either flavor on .c and .h files? (I know I would, I just blew close to an hour trying to figure out why it whined about a SPDX in a .h file I'm getting ready to upstream...)
[unhandled content-type:application/pgp-signature] | |