Messages in this thread | | | Date | Wed, 19 Jun 2019 14:40:27 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] [v2] ipsec: select crypto ciphers for xfrm_algo |
| |
On Tue, Jun 18, 2019 at 01:22:13PM +0200, Arnd Bergmann wrote: > kernelci.org reports failed builds on arc because of what looks > like an old missed 'select' statement: > > net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs': > xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash' > > I don't see this in randconfig builds on other architectures, but > it's fairly clear we want to select the hash code for it, like we > do for all its other users. As Herbert points out, CRYPTO_BLKCIPHER > is also required even though it has not popped up in build tests. > > Fixes: 17bc19702221 ("ipsec: Use skcipher and ahash when probing algorithms") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > net/xfrm/Kconfig | 2 ++ > 1 file changed, 2 insertions(+)
Acked-by: Herbert Xu <herbert@gondor.apana.org.au> -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |