lkml.org 
[lkml]   [2019]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dmaengine: qcom-bam: fix circular buffer handling
From
Date


On 6/18/2019 8:42 PM, Srinivas Kandagatla wrote:
>
>
> On 18/06/2019 15:56, Sricharan R wrote:
>>    So MAX_DESCRIPTORS is used in driver for masking head/tail pointers.
>>    That's why we have to pass MAX_DESCRIPTORS + 1 so that it works
>>    when the Macros does a size - 1
> Isn't that incorrect to do that, pretending to have more descriptors than we actually have?
>

The Macro's expect that buffer size is power of 2. So we are infact passing the actual correct
size ( MAX_DESCRIPTORS + 1 = 4096)

Regards,
Sricharan

--
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

\
 
 \ /
  Last update: 2019-06-18 18:28    [W:0.059 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site